fix: ensure <svelte:boundary>
properly removes error content in production mode
#15793
+69
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15674
When
DEV=false
, theshould_rethrow_error
check wasn't being performed, which led to errors during the initial mount not triggeringdestroy_effect
. This prevented proper removal of elements inside the boundary. I belive this issue relates to commit 10897ac.To address this, I've moved the DEV-specific logic into an explicit
if
block to distinguishes between DEV and non-DEV behaviors, ensuring consistency across both scenarios.I couldn't run test with
DEV=false
becauseDEV
is controlled by theNODE_ENV=production
viaesm-env
. So I've added a test case to simulate a similar condition by creating an error scenario wherecomponent_context
isnull
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint