Skip to content

Conversation

@Ocean-OS
Copy link
Member

Closes #16636, alternative to #16697.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2025

🦋 Changeset detected

Latest commit: 8ee268f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@github-actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16740

@Rich-Harris
Copy link
Member

Ah. This fails because filename is often absolute, meaning it differs based on where it runs. We don't have a good way to enforce project-relative filenames, and making builds non-deterministic seems bad. I'm now therefore of the opinion that we shouldn't make this change.

@Ocean-OS
Copy link
Member Author

What if we use the closest package.json to determine the project's root directory, and then replace any backslashes with slashes (so windows doesn't differ from everything else)?

@Rich-Harris
Copy link
Member

Oh actually, we have rootDir available... maybe we can just use that. Taking a run at it

@Rich-Harris Rich-Harris merged commit 68d27f1 into main Sep 10, 2025
18 checks passed
@Rich-Harris Rich-Harris deleted the gh-16636 branch September 10, 2025 20:52
@github-actions github-actions bot mentioned this pull request Sep 10, 2025
@Ocean-OS Ocean-OS mentioned this pull request Sep 12, 2025
6 tasks
sfriedel added a commit to nubolab-ffwd/svelte-fluent that referenced this pull request Nov 20, 2025
previous behavior broke snapshot tests in CI. caused by sveltejs/svelte#16740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hash styles by filename rather than contents

3 participants