Skip to content

fix: correctly SSR hidden="until-found" #16773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

fix: correctly SSR hidden="until-found" #16773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pink-gifts-sell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: correctly SSR hidden="until-found"
4 changes: 4 additions & 0 deletions packages/svelte/src/internal/shared/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ const replacements = {
*/
export function attr(name, value, is_boolean = false) {
if (value == null || (!value && is_boolean)) return '';
// attribute hidden for values other than "until-found" behaves like a boolean attribute
if (name === 'hidden' && value !== 'until-found') {
is_boolean = true;
}
const normalized = (name in replacements && replacements[name].get(value)) || value;
const assignment = is_boolean ? '' : `="${escape_html(normalized, true)}"`;
return ` ${name}${assignment}`;
Expand Down
1 change: 0 additions & 1 deletion packages/svelte/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ const DOM_BOOLEAN_ATTRIBUTES = [
'default',
'disabled',
'formnovalidate',
'hidden',
'indeterminate',
'inert',
'ismap',
Expand Down
1 change: 1 addition & 0 deletions packages/svelte/tests/runtime-runes/samples/attribute-spread-hidden-2/_expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<!--[--><div>A</div><div hidden>B</div><div hidden="until-found">C</div><!--]-->
3 changes: 3 additions & 0 deletions packages/svelte/tests/runtime-runes/samples/attribute-spread-hidden-2/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<div {...{ hidden: false }}>A</div>
<div {...{ hidden: true }}>B</div>
<div {...{ hidden: 'until-found' }}>C</div>
Loading