You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Often deriveds are currently unowned but through graph traversal during is_dirty() might reconnect to the graph, therefore having dependent effects register themselves as reactions.
The problem prior to this fix was that the graph was not traversed to update the derived's dependencies and unowned status of deriveds when batch_values contained the derived - the batch value was just returned then -, which results in reactivity loss. #17024 (comment) contains a detailed rundown of such a case. The fix is to still traverse the graph, though not executing any deriveds in the process or resetting signals.
Fixes#17024 Fixes#17049 (comment) (and therefore everything that was still buggy in that issue I think)
Before submitting the PR, please make sure you do the following
It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
Prefix your PR title with feat:, fix:, chore:, or docs:.
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.
If this PR changes code within packages/svelte/src, add a changeset (npx changeset).
Tests and linting
Run the tests with pnpm test and lint the project with pnpm lint
Often deriveds are currently unowned but through graph traversal during `is_dirty()` might reconnect to the graph, therefore having dependent effects register themselves as reactions.
The problem prior to this fix was that the graph was not traversed to update the derived's dependencies and unowned status of deriveds in batch_values - the batch value was just returned -, which results in reactivity loss. #17024 (comment) contains a detailed rundown of such a case. The fix is to still traverse the graph, though not executing any deriveds in the process.
Fixes#17024Fixes#17049 (comment) (and therefore everything that was still buggy in that issue I think)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Started noodling on an alternative approach in #17102. Interestingly though: when I copied the test in this PR to the sandbox, it worked fine? It only fails when run as a test. Doesn't appear to be a dev/prod discrepancy, I haven't been able to figure out what's going on
Have you increased the timeout in the test file long enough for the playground so you have a chance to click on the button before the async work stops?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Often deriveds are currently unowned but through graph traversal during
is_dirty()might reconnect to the graph, therefore having dependent effects register themselves as reactions.The problem prior to this fix was that the graph was not traversed to update the derived's dependencies and unowned status of deriveds when batch_values contained the derived - the batch value was just returned then -, which results in reactivity loss. #17024 (comment) contains a detailed rundown of such a case. The fix is to still traverse the graph, though not executing any deriveds in the process or resetting signals.
Fixes #17024
Fixes #17049 (comment) (and therefore everything that was still buggy in that issue I think)
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint