Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix is_hoistable cycle #2543

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Fix is_hoistable cycle #2543

merged 2 commits into from
Apr 25, 2019

Conversation

jches
Copy link
Contributor

@jches jches commented Apr 24, 2019

For exported function declarations, the child declaration is the node that gets added to the walking set, so we have to check that too to detect a cycle in this case

Closes #2542

@Rich-Harris Rich-Harris merged commit f888123 into sveltejs:master Apr 25, 2019
@Rich-Harris
Copy link
Member

wonderful, thank you!

@jches jches deleted the gh/2542 branch April 25, 2019 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is_hoistable causes "too much recursion" when exported functions reference each other
2 participants
@jches @Rich-Harris