Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if a figcaption's first element ancestor is a figure #2607

Merged
merged 1 commit into from
May 4, 2019
Merged

Check if a figcaption's first element ancestor is a figure #2607

merged 1 commit into from
May 4, 2019

Conversation

EmilTholin
Copy link
Member

This PR makes it so non-element ancestor blocks are discarded when checking if <figcaption> is an immediate child of <figure> and fixes #2582.

@Rich-Harris Rich-Harris merged commit 16dbb8f into sveltejs:master May 4, 2019
@Rich-Harris
Copy link
Member

nice, thanks

@EmilTholin EmilTholin deleted the figcaption_figure_first_element_ancestor branch May 4, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11y: <figcaption> must be an immediate child of <figure>
2 participants