A proof-of-concept fix for Custom Element Overrides #3184
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept change that fixes the issues with Custom Element Overrides detailed in issue #3182 where using the "is" property to define a native element overridden with a custom element does not work as expected.
The code is a bit of a cludge right now, as it's my first stab into this environment. As of 10554c9, it does not support binding the "is" property to an Expression. It would seem to me that in order to support this, one would have to remove and recreate the element entirely to support it correctly, and I do not know how to go about doing that.
Any feedback, tips, or admonishment welcome.