-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More robust handling of {@html ...}
#3329
Conversation
{@html ...}
Significantly simplifies the code for Where possible (e.g. I haven't checked yet, but I'm optimistic that it will also fix #3326. |
Confirmed this fixes #3326 — added a test |
Maybe these changes also fix #2711? |
Oh nice, yeah it looks like it fixes that as well. |
Actually, the REPLs in the first and third comments in the issue seem fixed with this PR. The second REPL still has something weird going on. |
Started working on this but just going to leave a failing test here for now. Basically, too much is happening during mount — when something is remounted (i.e. after a list shuffle) new DOM is created. We probably need an abstraction for handling fragments generated from HTML.