Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make void element test case insensitive #340

Closed
wants to merge 1 commit into from

Conversation

Conduitry
Copy link
Member

Fixes #336, but also fixes other issues where writing a void element in anything but lowercase would throw an error.

@Conduitry
Copy link
Member Author

Eep I don't know what the heck these build failures are about

@Conduitry
Copy link
Member Author

Hm. I don't know what a good way to handle this would be. The issue is the <Link> component used in a few tests. With this change, the parser now expects that to be a void element. Should components not be allowed to have the same names (case insensitively) as void elements? One other possibility would be to specifically exclude any elements that match a component we're declaring we're using - but at the stage where we're parsing the HTML, we probably don't know yet what the components are.

@Conduitry
Copy link
Member Author

Running into some other weird case sensitivity stuff, making me think that more normalization is needed, rather than just changing this one regex. I'll open another issue.

@Conduitry
Copy link
Member Author

IMO #341 is how this should all be addressed instead. But that still leaves open the question of how to handle components whose names are the same as void elements.

@Conduitry
Copy link
Member Author

I'm going to close this PR without merging it. The important stuff has also been captured elsewhere, and the way forward is going to be a bit more complicated than this.

@Conduitry Conduitry closed this Mar 6, 2017
@Conduitry Conduitry deleted the case-insensitive-void-elements branch March 12, 2017 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

!doctype causes an error
1 participant