Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed complex {#if} behaviour #3452

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/compile/render_dom/wrappers/IfBlock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ export default class IfBlockWrapper extends Wrapper {
}
`;

if (branch.snippet) {
if (branch.snippet && branch.dependencies.length) {
block.builders.update.add_block(`if (${branch.dependencies.map(n => `changed.${n}`).join(' || ')}) ${branch.condition} = ${branch.snippet}`);
}

Expand Down
93 changes: 93 additions & 0 deletions test/js/samples/if-block-complex/expected.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
/* generated by Svelte vX.Y.Z */
import {
SvelteComponent,
attr,
detach,
element,
empty,
init,
insert,
noop,
safe_not_equal
} from "svelte/internal";

// (7:0) {#if (item.divider && item.divider.includes(1))}
function create_if_block(ctx) {
var div;

return {
c() {
div = element("div");
attr(div, "class", "divider");
},

m(target, anchor) {
insert(target, div, anchor);
},

d(detaching) {
if (detaching) {
detach(div);
}
}
};
}

function create_fragment(ctx) {
var show_if = (ctx.item.divider && ctx.item.divider.includes(1)), if_block_anchor;

var if_block = (show_if) && create_if_block(ctx);

return {
c() {
if (if_block) if_block.c();
if_block_anchor = empty();
},

m(target, anchor) {
if (if_block) if_block.m(target, anchor);
insert(target, if_block_anchor, anchor);
},

p(changed, ctx) {
if (show_if) {
if (!if_block) {
if_block = create_if_block(ctx);
if_block.c();
if_block.m(if_block_anchor.parentNode, if_block_anchor);
}
} else if (if_block) {
if_block.d(1);
if_block = null;
}
},

i: noop,
o: noop,

d(detaching) {
if (if_block) if_block.d(detaching);

if (detaching) {
detach(if_block_anchor);
}
}
};
}

function instance($$self) {
let item = {
divider: [1]
}

return { item };
}

class Component extends SvelteComponent {
constructor(options) {
super();
init(this, options, instance, create_fragment, safe_not_equal, []);
}
}

export default Component;
9 changes: 9 additions & 0 deletions test/js/samples/if-block-complex/input.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<script>
let item = {
divider: [1]
}
</script>

{#if (item.divider && item.divider.includes(1))}
<div class="divider"></div>
{/if}