Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reactive updates not reflected when handle promise #3663

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Oct 6, 2019

Fix #3660

Added a test that would fail otherwise (test/runtime/samples/await-set-simultaneous-reactive/)

When flushing changes after promise, the newly attached block is not updated.
This is more obvious, when the newly attached block props takes value from a reactive declared variables, because their value only changed right before patching the dom

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@@ -0,0 +1,7 @@
let _resolvePromise;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like this file is actually used in the test.

@Conduitry Conduitry merged commit 7d9262c into sveltejs:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bind:this used in {#await} does not trigger reaction
2 participants