Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: if inside bind await block contextual dependencies #4065

Merged
merged 1 commit into from
Dec 9, 2019
Merged

fix: if inside bind await block contextual dependencies #4065

merged 1 commit into from
Dec 9, 2019

Conversation

tanhauhau
Copy link
Member

Fix #4044

in IfBlockBranch will call expression.manipulate(block) in the constructor. which is called before adding the value and error into context dependencies.

@ghost
Copy link

ghost commented Dec 9, 2019

@tanhauhau, nice concise fix!
Thanks for the explanation as well!

@Conduitry Conduitry merged commit 468938c into sveltejs:master Dec 9, 2019
@tanhauhau tanhauhau deleted the tanhauhau/fix-await-then-if branch December 9, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

{#if} inside {#await} doesn't work
2 participants
@tanhauhau @Conduitry