Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssr for group bindings #4621

Merged
merged 3 commits into from
Jul 10, 2021
Merged

add ssr for group bindings #4621

merged 3 commits into from
Jul 10, 2021

Conversation

jonniek
Copy link
Contributor

@jonniek jonniek commented Apr 1, 2020

This PR implements server-rendering for group bindings. I noticed this TODO comment and attempted to add the feature.

// TODO server-render group bindings

This commit covers the following cases

  • group value is a string: checked if value strict equals group value
  • group value is an array: checked if value is included in group value array

I didn't see any other data structures for group bindings in docs so I hope this covers everything.

@stale
Copy link

stale bot commented Jun 26, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tanhauhau tanhauhau merged commit 7bcbe67 into sveltejs:master Jul 10, 2021
@jonniek jonniek deleted the group branch July 13, 2021 17:17
@Conduitry
Copy link
Member

Conduitry commented Jul 21, 2021

This has been released in 3.39.0 - thank you for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants