Tutorial : a better explanation of component events #4639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Antony Jones <ant@enzy.org>
Co-Authored-By: Antony Jones <ant@enzy.org>
…uhMeuh/svelte into 04-component-event-better-explanation
|
Hello @antony , up :) CI has been fixed (this PR is quite old but I updated my branch from the latest changes on master and checked that everything was fine). |
|
Thanks! I'll see if we can get this merged soon :) |
|
Hi @antony ! Any news about this ? It may be a bit late now ? Thx ! |
dummdidumm
approved these changes
Nov 18, 2020
|
Hi, should I close this ? |
|
@MeuhMeuh no, we'll get to merging it as soon as we are in a position to do so. |
antony
approved these changes
Feb 4, 2021
hontas
added a commit
to hontas/svelte
that referenced
this pull request
Feb 11, 2021
* 'master' of https://github.com/sveltejs/svelte: (129 commits) -> v3.32.3 fix remove of lone :host selectors (sveltejs#5984) -> v3.32.2 update changelog fix extra invalidation with component prop binding to object property (sveltejs#5890) update css-tree@^1.1.2 (sveltejs#5958) fix :host and :global css scoping (sveltejs#5957) Tutorial : a better explanation of component events (sveltejs#4639) "What's new in Svelte" February newsletter (sveltejs#5925) Change color on 404 page (sveltejs#5932) -> v3.32.1 warn module variables are nonreactive and make them truly nonreactive (sveltejs#5847) update changelog fix: "foreign" namespace elements should still allow binding 'this' (sveltejs#5942) inline `prop_values` in `init` helper (sveltejs#5909) update changelog don't create class update functions when dependencies aren't reactive (sveltejs#5926) fix extraneous store subscription in SSR (sveltejs#5929) make `SvelteComponentDev` typings more forgiving (sveltejs#5937) make animation/transition params optional (sveltejs#5936) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to this issue: #4642
This is an attempt to make the
04 - component - eventstutorial section a bit clearer about what it does on the "listener" side. The goal is to have people who go through the tutorial understand better how the event system works, as it is not covered in the next sections of the tutorial.I just added a paragraph at the end explaining the
on:messageattribute and why it is there.The next sections talk about events, but not about this specific
on:messageattribute that matters in my opinion (how it works, why it is named like this, etc).Before submitting the PR, please make sure you do the following
npm run lint!)Tests
npm testoryarn test)