Fix: bind:this in each with objects\array #4759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4686
Code from issue
Adding dependecies only use single variable name (
itemId
), but it can be too hard to detect what arrayitems1[itemId]
anditems2[itemId]
are different.If you use it carefully, there will be no problems. Also, detecting different variable names can be bypassed by using variable reference (something like
let items1 = []; let items2 = items1;
)Also i add two tests (one with object props, and one with spread)
PS: also i look to issue #4636, but this is another issue that is not directly related to this one