Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set select multiple value with spread #4894

Merged
merged 3 commits into from
May 26, 2020
Merged

set select multiple value with spread #4894

merged 3 commits into from
May 26, 2020

Conversation

tanhauhau
Copy link
Member

Fixes #4392

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@tanhauhau tanhauhau force-pushed the tanhauhau/fix-select-multiple-with-spread branch from fffe7d5 to 7243c39 Compare May 23, 2020 13:41
@tanhauhau tanhauhau force-pushed the tanhauhau/fix-select-multiple-with-spread branch from 7243c39 to 7dfa361 Compare May 25, 2020 14:33
@Conduitry Conduitry merged commit 24ef4e1 into sveltejs:master May 26, 2020
@tanhauhau tanhauhau deleted the tanhauhau/fix-select-multiple-with-spread branch May 27, 2020 01:01
@jthegedus jthegedus mentioned this pull request May 31, 2020
Merged
4 tasks
@TylerRick TylerRick mentioned this pull request Nov 4, 2020
Closed
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@tanhauhau @taylorzane
set select multiple value with spread (sveltejs#4894)
9620b0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select multiple value does not get set with spread props
2 participants
@tanhauhau @Conduitry