rename root to state, and allow state to be used as context #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that "can't use |
Conduitry
approved these changes
Apr 19, 2017
Conduitry
reviewed
Apr 19, 2017
| @@ -79,7 +79,7 @@ function create_each_block ( root, each_block_value, comment, i, component ) { | |||
| var text_2 = createText( text_2_value = comment.author ); | |||
| appendNode( text_2, span ); | |||
| appendNode( createText( " wrote " ), span ); | |||
| var text_4 = createText( text_4_value = root.elapsed(comment.time, root.time) ); | |||
| var text_4 = createText( text_4_value = state.elapsed(comment.time, root.time) ); | |||
There was a problem hiding this comment.
Looks like this one root was missed in the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This scratches a long-standing itch (#507) and fixes a bug whereby this would fail:
{{#each roots as root}} {{root}} {{/each}}The
stateequivalent now works, asstateis treated as a reserved word.