Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix function slot props based on context #5607

Merged
merged 3 commits into from
Oct 29, 2020
Merged

fix function slot props based on context #5607

merged 3 commits into from
Oct 29, 2020

Conversation

tanhauhau
Copy link
Member

Fixes #5565

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@tanhauhau tanhauhau force-pushed the tanhauhau/gh-5565-slot-context branch from 8d38732 to 6fa2ae8 Compare October 28, 2020 17:25
@Conduitry Conduitry merged commit 5d7ffdb into sveltejs:master Oct 29, 2020
@tanhauhau tanhauhau deleted the tanhauhau/gh-5565-slot-context branch November 23, 2020 09:05
@tanhauhau tanhauhau mentioned this pull request Dec 1, 2020
Merged
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@tanhauhau @taylorzane
fix function slot props based on context (sveltejs#5607)
ed226d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid code generated when a slot prop in an #each is a function that depends on the #each context.
2 participants
@tanhauhau @Conduitry