Fix yield block placement #563
Conversation
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
==========================================
+ Coverage 87.78% 87.79% +<.01%
==========================================
Files 95 95
Lines 2866 2867 +1
==========================================
+ Hits 2516 2517 +1
Misses 350 350
Continue to review full report at Codecov.
|
| const parentNode = state.parentNode || block.target; | ||
|
|
||
| ( state.parentNode ? block.builders.create : block.builders.mount ).addLine( | ||
| `if ( ${block.component}._yield ) ${block.component}._yield.mount( ${parentNode}, null );` |
There was a problem hiding this comment.
Is there a reason for switching this (and the destroy block below) to a regular if from a short circuited &&? Just a style thing? It seems we're relying on short circuiting in generated code for conciseness elsewhere.
There was a problem hiding this comment.
No particular reason, just saw it and thought there's no reason it shouldn't be an if — the intent is clearer, and it minifies the same way. I reckon we should generally prefer if to && for statements (as opposed to expressions). Don't feel all that strongly though
Fixes #561