Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] increase test coverage #565

Merged
merged 7 commits into from
May 4, 2017
Merged

[WIP] increase test coverage #565

merged 7 commits into from
May 4, 2017

Conversation

Rich-Harris
Copy link
Member

Codecov has mysteriously started commenting on pull requests again, which reminds me that we should try and get our coverage a bit higher:

https://codecov.io/gh/sveltejs/svelte

@codecov-io
Copy link

codecov-io commented May 4, 2017

Codecov Report

Merging #565 into master will increase coverage by 6.63%.
The diff coverage is 93.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
+ Coverage   87.78%   94.42%   +6.63%     
==========================================
  Files          95       95              
  Lines        2866     2744     -122     
==========================================
+ Hits         2516     2591      +75     
+ Misses        350      153     -197
Impacted Files Coverage Δ
src/generators/dom/visitors/Element/meta/Window.js 77.35% <ø> (+2.35%) ⬆️
src/generators/dom/index.js 97.56% <ø> (ø) ⬆️
src/validate/utils/FuzzySet.js 88.62% <ø> (ø)
src/validate/utils/list.js 100% <100%> (ø)
src/generators/dom/visitors/IfBlock.js 100% <100%> (+31.81%) ⬆️
src/validate/js/index.js 92.3% <100%> (-0.2%) ⬇️
src/validate/utils/fuzzymatch.js 100% <100%> (ø)
src/validate/js/propValidators/namespace.js 81.81% <100%> (-1.52%) ⬇️
src/validate/html/validateWindow.js 100% <100%> (ø)
src/validate/html/validateElement.js 78.12% <100%> (-4.49%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a7f7e2...b342f2e. Read the comment docs.

@Rich-Harris
Copy link
Member Author

Alright, taking a break from this for a bit. Coverage is now almost at 95%, and I found and fixed a couple of bugs while going through this process

@Rich-Harris Rich-Harris merged commit cedd318 into master May 4, 2017
@Rich-Harris Rich-Harris deleted the coverage branch May 4, 2017 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants