-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Convert to TypeScript #573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have done a bit more work on this — still some squiggly red lines, but far fewer. Merging this in so it doesn't get in the way of any other work |
Merged
Happy to help with porting to TS 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a small start on converting the project to TypeScript (#508) — just changing a couple of file extensions, updating the build process, and adding a handful of annotations.
Right now my editor is a distracting sea of squiggly red lines, but to be honest I'm not entirely sure what I'm doing, so if anyone is keen to help out then please do! I'll take a step back from this branch for a bit. If we're agreed on going down this road (and it seems like a good idea from the enthusiastic response on #508) then we should probably make this happen before addressing any other issues, otherwise we'll never escape from merge conflict hell.