Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating css-tree lib & creating media-query-calc test - #5876 #5888

Closed
wants to merge 1 commit into from
Closed

Updating css-tree lib & creating media-query-calc test - #5876 #5888

wants to merge 1 commit into from

Conversation

Victomas97
Copy link

@Victomas97 Victomas97 commented Jan 16, 2021

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

THIS ISSUE IS NOT FINISHED BEACUSE I HAVE SOME QUESTIONS.

Hi! I'm new here. I created a test to try media-query-calc and i tryied to update css-tree because this current version don't support media queries calc... But I have some problems on compiles.js and obviusly i can't commit it.
SOME HELP!?

@Victomas97 Victomas97 changed the title Updating css-tree lib & creating media-query-calc test Updating css-tree lib & creating media-query-calc test - #5876 Jan 16, 2021
@benmccann benmccann marked this pull request as draft January 18, 2021 04:55
@ludofischer
Copy link

Did you run the existing tests? When I updated css-tree, many tests failed. If I remember correctly I got a lot of 'maximum stack depth' errors. Is that also what you are seeing?

@benmccann
Copy link
Member

Closing in favor of #5958

@benmccann benmccann closed this Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants