Add filename to combined source map if needed #6089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When source maps are combined and the leading map is empty, sources is not set. Add the filename to the empty array in this case. This may be an upstream issue (but maybe it's also intended, let's see) but either way for our cases it's necessary to set
sources
even for empty maps.They were not added before this change so I adjusted the tests. The
js.map
output now is closer to what it would be like if there was no preprocessing and there's no JS - in that case Svelte outputs an empty map withsources
set which looks like thisRelated sveltejs/kit#424
Before submitting the PR, please make sure you do the following
Tests
npm test
and lint the project withnpm run lint