Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] exclude svg_element function if no svg element in a component #6556

Conversation

tomoam
Copy link
Contributor

@tomoam tomoam commented Jul 22, 2021

fixes #6555

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@tanhauhau
Copy link
Member

tanhauhau commented Jul 22, 2021

by the same token, shouldn't @element be excluded too if it is a fully svg element?

@Conduitry
Copy link
Member

Yeah that was mentioned in the original issue. I think that makes sense, as it's probably not uncommon to have an all-SVG component.

@tomoam
Copy link
Contributor Author

tomoam commented Jul 23, 2021

Thanks for your comments. I'll try to work on it.

@tomoam
Copy link
Contributor Author

tomoam commented Jul 27, 2021

ref: #6555 (comment)

I fixed it up. Please review.

@Conduitry Conduitry merged commit 907223c into sveltejs:master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svg_element function is output even if no svg element in a component
3 participants