Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] handle preprocess with empty sourcemaps #6757

Merged
merged 1 commit into from
Sep 22, 2021
Merged

[fix] handle preprocess with empty sourcemaps #6757

merged 1 commit into from
Sep 22, 2021

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 22, 2021

Fixes sveltejs/svelte-preprocess#412

Handles preprocessors that return empty sourcemaps like { mappings: '' }, which is valid per rollup documentation.

cc @dominikg

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@dominikg
Copy link
Member

looks good. is there any way to blame the offending preprocessor and/or notify the user about the potentially broken result?

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We thought about adding a warning before but shied away from it because it would probably pollute the output in most cases without the user being able to do much about it

@Conduitry Conduitry merged commit b845307 into sveltejs:master Sep 22, 2021
@bluwy bluwy deleted the fix-preprocess-empty-sourcemaps branch September 22, 2021 17:39
@Conduitry
Copy link
Member

This has been released in 3.43.0 - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is it working with coffeescript?
4 participants