Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] "What's new in Svelte" November newsletter #6888

Merged
merged 6 commits into from
Nov 2, 2021
Merged

[docs] "What's new in Svelte" November newsletter #6888

merged 6 commits into from
Nov 2, 2021

Conversation

DreaminDani
Copy link
Contributor

Sorry this is coming in so late! I moved this month and have just barely gotten the laptop unpacked.

Feel free to add anything I missed, especially around the new changes in SvelteKit 😄

@Mlocik97
Copy link
Contributor

Mlocik97 commented Nov 1, 2021

https://anovokmet.github.io/svelte-gantt/ is really nice project, can we add it?

@benmccann
Copy link
Member

I'm guess you did "start a review" rather than leaving individual comments. There should be a button that says something like "finish review" in the upper-right if I remember correctly

@DreaminDani
Copy link
Contributor Author

Thanks for all the feedback, y'all! I think this is ready to merge when y'all are :)

DreaminDani and others added 2 commits November 1, 2021 21:52
@DreaminDani @benmccann
Apply suggestions from code review
d2a527d 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@DreaminDani @benmccann
more specific config update
e59d73d 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@dummdidumm dummdidumm merged commit 530b6ae into sveltejs:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffrich geoffrich geoffrich left review comments

@steven-lay steven-lay steven-lay left review comments

@Conduitry Conduitry Conduitry left review comments

@ryanfiller ryanfiller ryanfiller left review comments

@bluwy bluwy bluwy left review comments

@Mlocik97 Mlocik97 Mlocik97 left review comments

@benmccann benmccann benmccann approved these changes

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@DreaminDani @Mlocik97 @benmccann @geoffrich @dummdidumm @steven-lay @Conduitry @ryanfiller @bluwy