Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]: Add A11y aria-proptypes check #6978

Merged
merged 5 commits into from
Jul 11, 2022
Merged

[feat]: Add A11y aria-proptypes check #6978

merged 5 commits into from
Jul 11, 2022

Conversation

kwangure
Copy link
Contributor

@kwangure kwangure commented Dec 2, 2021

This PR implements the aria-proptypes a11y check in #820.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@tanhauhau tanhauhau mentioned this pull request Jul 11, 2022
Closed
8 tasks
@tanhauhau tanhauhau merged commit 3990198 into sveltejs:master Jul 11, 2022
@Conduitry
Copy link
Member

This has been released in 3.50.0. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanhauhau tanhauhau tanhauhau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kwangure @Conduitry @tanhauhau @mka8