[fix] runtime: destroy missing fragment #6996
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
[feat]
,[fix]
,[chore]
, or[docs]
.Tests
npm test
and lint the project withnpm run lint
Problem
When manually removing a HTML element from a component, it is trying to be accessed later on in the destroy lifecycle where it throws an error.
This PR adds optional chaining before accessing
removeChild
from theparentNode
property to prevent the error thrown.I prepared a REPL where this fails => https://svelte.dev/repl/0d826c0d67c54d8693aeaa1b77ea09ef?version=3.44.2