[fix] textContent should not be set for <template> element.

[lidlanca]

fix inconsistent rendering of template tags, where text only content is not inserted in the fragment (.content)
elements directly under a template element is non standard, and may break some functionality
for example $(template).innerHTML will be empty when elements are not part of the fragment.

current behavior

A)<template>123</template>

B)<template>1+2={1+2}</template>

C)<template><b>inside</b></template>

for A, B content is not part of the template fragment(.content)

[bluwy]

Thanks for the explanation and refactor! This makes sense to me. It would be great to have a test for this too to prevent regressions.

[lidlanca]

Thanks for the explanation and refactor! This makes sense to me. It would be great to have a test for this too to prevent regressions.

I assume we are looking for a snapshot testing of the compiler output

where should this test be

[bluwy]

There's https://github.com/sveltejs/svelte/blob/dispatch-cancelable/test/runtime/samples/template/_config.js currently, but that checks things imperatively. I think something similar could be done instead of a snapshot by checking for textContent or innerHtml for this specific case?

[lidlanca]

I tried modifying this test, to make some assertions on the dom
however, when the test is invoked

test({ assert, target }) {
...
}}

target for <template>123</template> case.
does not have content populated,

my guess svelte component has c() and m(), and .content is set in m()
I don't know when m() is suppose to be called, or if at all possible to trigger ,
this type of test seem to be very limiting, or I lack the understanding.

[bluwy]

m() should have been called before running the test. Is the fix applied when running the tests? If 123 is inside the document fragment, .content.textContent should be 123.

[lidlanca]

tests should be passing now.

[bluwy]

LGTM 👍 Thanks for adding the tests.

[Conduitry]

This has been released in 3.48.0 - thanks!