Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix sentence of <svelte:element> #7484

Merged
merged 3 commits into from
Apr 25, 2022
Merged

[docs] fix sentence of <svelte:element> #7484

merged 3 commits into from
Apr 25, 2022

Conversation

baseballyama
Copy link
Member

If the tag is changed, the children will be preserved unless there's a transition attached to the element.

Child elements are always regenerated when tag is changed. So I removed this sentence.

If this has a nullish value, a warning will be logged in development mode.

Now the warning is not showing. nullish value is officially supported.
So I updated the sentence.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Co-authored-by: Ignatius Bagus <ignatius.mbs@gmail.com>
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Copy link
Member

@ignatiusmb ignatiusmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dummdidumm dummdidumm merged commit 11ada98 into sveltejs:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants