feat: add a11y no-noninteractive-element-to-interactive-role

[ngtr6788]

Hey everyone, this is my first time contributing to the Svelte project as well as open source in general. 👋

I noticed that there are a few accessibility checks remaining in #820 and I picked up no-noninteractive-element-to-interactive-role (not to be confused by no-interactive-element-to-noninteractive-role, which was already done #5955).

However, I have a small question: There are cases where this rule doesn't apply if we set it under eslint-jsx recommended settings but is applied under strict settings. Are we using the strict settings here? (edited because I asked another question and already found the answer)

My test plan:

• Test random combinations of non-interactive elements with interactive roles
• Test div-role combinations
• Test non-interactive roles with non-interactive elements to make sure the rule doesn't pick those

Let me know if there are improvements or comments you want to make!

Before submitting the PR, please make sure you do the following

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• Prefix your PR title with [feat], [fix], [chore], or [docs].
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with npm test and lint the project with npm run lint

[vercel]

@ngtr6788 is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

[dummdidumm]

As noted in #8251 (comment), could you keep the boolean methods (making them simple wrapper methods of your new enum-returning methods)? This would reduce the things changed and (IMO) makes the code a bit more readable on the usage side. Code looks good otherwise!

[ngtr6788]

Sounds good! I just pushed the wrapper method you mentioned now!

[dummdidumm]

Thank you!

[Conduitry]

This has been released in 3.57.0 - thank you!

[ngtr6788]

You're welcome!