Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert buggy reactive vars optimization #8382

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

dummdidumm
Copy link
Member

Reverts #7942
Fixes #8374

FYI @tanhauhau I'm proposing to revert the change - the optimization seems small in comparison to the potential maintenance overhead (and the bug) it introduces. If you disagree, you're welcome to propose a different PR which fixes #8374 instead. I'll merge this later this week if no objections.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@vercel
Copy link

vercel bot commented Mar 14, 2023

@dummdidumm is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@benmccann benmccann changed the title (fix) revert buggy reactive vars optimization fix: revert buggy reactive vars optimization Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactive variable no longer reacting in 3.56.0
1 participant