-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: call all event handlers even if an exception occurs in one #8443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a816f02
svelte-display implementation
adiguba d983d63
Merge branch 'master' into master
adiguba 70ec60c
Merge branch 'master' into master
adiguba 9e9b135
Merge remote-tracking branch 'upstream/master'
adiguba 8c422a4
Merge branch 'master' of https://github.com/adiguba/svelte
adiguba fdd7226
Merge remote-tracking branch 'upstream/master'
adiguba 4e0ba4f
Merge branch 'master' of https://github.com/adiguba/svelte
adiguba ae57475
rollback to upstream/master
adiguba 26b3cbe
catch and report errors on handler
adiguba 668ed8c
clean code
adiguba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question for more knowledgeable reviewers: will this file be called during ssr? if so, we probably need to fix this reference to
window. also note thatreportErroris not yet supported in NodeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I miss that component events can be triggered in SSR !
Don't know how to handle this correctly...