Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade rollup #8491

Merged
merged 4 commits into from
Apr 12, 2023
Merged

chore: upgrade rollup #8491

merged 4 commits into from
Apr 12, 2023

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Apr 12, 2023

This just upgrades to Rollup 2 for now. I was having more trouble with Rollup 3 and think that might be easier after we adopt "type": "module". This does upgrade all the plugins fully though, so it's just the core library that will be left

@vercel
Copy link

vercel bot commented Apr 12, 2023

@benmccann is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@dummdidumm
Copy link
Member

dummdidumm commented Apr 12, 2023

Managed to get it working for Rollup 3. This unvailed some weird conventions I wasn't aware of before, which I replaced with another slightly less weird convention. TLDR there needs to be a way for the different bundles (store/internal/etc) to reference each other without bundling the imported other file (which will be a bundle). Previously it relied on svelte/x and transforming to a relative import, but that was mentioned nowhere and might lead to accidentally wrong packages if someone in the future does a relative import (because that's the more sensible way to import things). Now relative imports are used and the rollup was adjusted accordingly.

@dummdidumm dummdidumm merged commit c9ccd6e into sveltejs:version-4 Apr 12, 2023
@benmccann
Copy link
Member Author

wow. thank you @dummdidumm! that was quite the tricky upgrade

@benmccann benmccann added this to the 4.x milestone Apr 12, 2023
@benmccann benmccann deleted the rollup branch April 12, 2023 19:37
dummdidumm added a commit that referenced this pull request Apr 18, 2023
bump to rollup 3. Includes reworking the "treat those imports as external" a bit so that Rollup builds correctly but doesn't bundle some of the (now relative) imports

---------

Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
@gtm-nayan gtm-nayan mentioned this pull request Jun 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants