Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: migration page #8739

Merged
merged 14 commits into from
Jun 19, 2023
Merged

docs: migration page #8739

merged 14 commits into from
Jun 19, 2023

Conversation

dummdidumm
Copy link
Member

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@dummdidumm dummdidumm added this to the 4.x milestone Jun 15, 2023
@benmccann
Copy link
Member

libraries will need to be updated to include || ^4 in the peerDependencies. svelte-migrate doesn't do that one automatically, so we should probably note it here

@benmccann
Copy link
Member

We may also want to note inline in the docs some things that were different in v3 assuming we're not hosting a separate version of the docs for v3. I made some notes about those here: #8703

@dummdidumm
Copy link
Member Author

Added a note about the peerDependencies. The other changes you mentioned can go into a separate PR.

@benmccann
Copy link
Member

I'm not sure about the URL migrating-v3-to-v4. Maybe it should be something like v4-migration-guide?

benmccann
benmccann reviewed Jun 16, 2023
View reviewed changes
documentation/docs/05-misc/04-migrating-v3-to-v4.md Outdated

## Transitions are local by default

Transitions are now local by default to prevent confusion around page navigations. To make them global, add the `|global` modifier. The migration script will do this automatically for you. ([#6686](https://github.com/sveltejs/svelte/issues/6686))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we have time, it'd be nice to make this optional

dummdidumm and others added 5 commits June 16, 2023 15:08
@dummdidumm @benmccann
Update documentation/docs/05-misc/04-migrating-v3-to-v4.md
d0a21c0 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@dummdidumm @benmccann
Update documentation/docs/05-misc/04-migrating-v3-to-v4.md
55b950d 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@dummdidumm @benmccann
Update documentation/docs/05-misc/04-migrating-v3-to-v4.md
382dd45 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@dummdidumm @benmccann
Update documentation/docs/05-misc/04-migrating-v3-to-v4.md
f8448df 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@dummdidumm
Update and rename 04-migrating-v3-to-v4.md to 04-v4-migration-guide.md
b1f9197
Base automatically changed from sites to version-4 June 16, 2023 15:45
@dummdidumm dummdidumm merged commit 75917ee into version-4 Jun 19, 2023
@dummdidumm dummdidumm deleted the migration-docs branch June 19, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollema ollema ollema left review comments

@benmccann benmccann benmccann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dummdidumm @benmccann @ollema