Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply transition_in/out to svelte:element with local transition #8865

Merged
merged 2 commits into from
Jun 28, 2023
Merged

fix: apply transition_in/out to svelte:element with local transition #8865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12c9676
fix #8233 svelte:element local transition not applied
Jun 28, 2023
836f233
Update .changeset/neat-feet-accept.md
dummdidumm Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-feet-accept.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: apply transition to `<svelte:element>` with local transition
16 changes: 12 additions & 4 deletions packages/svelte/src/compiler/compile/render_dom/wrappers/Element/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,14 @@ export default class ElementWrapper extends Wrapper {
strip_whitespace,
next_sibling
);

// in the case of `parent_block -> child_dynamic_element_block -> child_dynamic_element`
// `child_dynamic_element_block.add_intro/outro` is called inside `new ElementWrapper()`
// but when `is_local === true` it does not bubble to parent_block
// we manually add transitions back to the parent_block (#8233)
if (node.intro) block.add_intro(node.intro.is_local);
if (node.outro) block.add_outro(node.outro.is_local);

// the original svelte:element is never used for rendering, because
// it gets assigned a child_dynamic_element which is used in all rendering logic.
// so doing all of this on the original svelte:element will just cause double
Expand Down Expand Up @@ -266,10 +274,10 @@ export default class ElementWrapper extends Wrapper {
this.event_handlers = this.node.handlers.map(
(event_handler) => new EventHandler(event_handler, this)
);
if (node.intro || node.outro) {
if (node.intro) block.add_intro(node.intro.is_local);
if (node.outro) block.add_outro(node.outro.is_local);
}

if (node.intro) block.add_intro(node.intro.is_local);
if (node.outro) block.add_outro(node.outro.is_local);

if (node.animation) {
block.add_animation();
}
Expand Down