Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint matches existing structure and solution #8915

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

chhotii-alex
Copy link
Contributor

In the discussion there's a hint-- a bit of code that, when added to the existing code, gives the solution to the problem. The bit of code in the hint does not match the pre-existing code or the solution in these ways: 1) different variable name-- number vs. value
2) what transition to use
3) whether to use the transition attribute or the in attribute I have just changed the markup so that the suggested code matches what needs to be added to most quickly arrive at the solution. Otherwise the learner has to also fix/grapple with these other differences.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

In the discussion there's a hint-- a bit of code that, when added to the existing code, gives the solution to the problem. The bit of code in the hint does not match the pre-existing code or the solution in these ways:
1) different variable name-- number vs. value
2) what transition to use
3) whether to use  the transition attribute or the in attribute
I have just changed the markup so that the suggested code matches what needs to be added to most quickly arrive at the solution. Otherwise the learner has to also fix/grapple with these other differences.
@dummdidumm dummdidumm merged commit bb5d394 into sveltejs:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants