-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade vitest #8939
chore: upgrade vitest #8939
Conversation
Is there any way to avoid the two simultaneous versions of esbuild this gives us? |
vite 4.4 uses 0.18 , latest vitest should too. |
We just need to merge sveltejs/kit#10330 and then update to the latest |
It looks like happy-dom 9.20.3 is being used by vitest even before this PR, which means you should be able to address this TODO now:
Mind sneaking a fix for that into this PR? |
Looks like happy-dom has a few more bugs, just removed the todo for now. It's a small suite so we won't get much difference in speed either. |
renovate won't do it because semver
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint