Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade vitest #8939

Merged
merged 12 commits into from
Jul 11, 2023
Merged

chore: upgrade vitest #8939

merged 12 commits into from
Jul 11, 2023

Conversation

gtm-nayan
Copy link
Contributor

renovate won't do it because semver

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@Conduitry
Copy link
Member

Is there any way to avoid the two simultaneous versions of esbuild this gives us?

@dominikg
Copy link
Member

dominikg commented Jul 8, 2023

vite 4.4 uses 0.18 , latest vitest should too. pnpm dedupe could do, otherwise adding an override to package.json, but overriding it risks breaking something.

@benmccann
Copy link
Member

We just need to merge sveltejs/kit#10330 and then update to the latest adapter-vercel in the sites directory here. Anyone want to give sveltejs/kit#10330 an approval? 😉

@benmccann
Copy link
Member

It looks like happy-dom 9.20.3 is being used by vitest even before this PR, which means you should be able to address this TODO now:

// TODO: https://github.com/capricorn86/happy-dom/issues/916

Mind sneaking a fix for that into this PR?

@gtm-nayan
Copy link
Contributor Author

Looks like happy-dom has a few more bugs, just removed the todo for now. It's a small suite so we won't get much difference in speed either.

@benmccann benmccann merged commit 33fd631 into master Jul 11, 2023
@benmccann benmccann deleted the bump-vitest branch July 11, 2023 16:47
@benmccann benmccann mentioned this pull request Jul 25, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants