-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve types for props when using Client-side component API #8950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that probably counts as a breaking change - also since #8872 I'm kinda nervous to use never
as an explicit descriptor to define "this component does not accept props". null
is probably better for this.
Ah, didn't knew about this issue. I updated it to use |
@@ -0,0 +1,5 @@ | |||
--- | |||
'svelte': major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be minor, unless its for svelte 5? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated it because it is a breaking change ^^. So it belongs to version 5, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct. Marking this as draft so it's not accidentally merged early.
The types are more restrictive, but you wouldn't have been able to pass something that doesn't conform to these types without the code at least breaking at runtime I think? So maybe it's not really a breaking change? |
The new |
fix for sveltejs/language-tools#1578
In theory this is a breaking change. So maybe it needs to wait for version 5 of
Svelte
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint