Skip to content

Conversation

PuruVJ
Copy link
Collaborator

@PuruVJ PuruVJ commented Aug 18, 2023

Bumps deps. Updates site-kit, which relies on async Marked functions and Marked instance

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2023

⚠️ No Changeset found

Latest commit: b5b0d2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me. I'd merge it except that it's in draft state

@PuruVJ
Copy link
Collaborator Author

PuruVJ commented Aug 21, 2023

Waiting for site-kit release, until then it has to be on hold

@PuruVJ PuruVJ marked this pull request as ready for review August 21, 2023 09:45
@PuruVJ PuruVJ merged commit f2ead82 into master Aug 22, 2023
@PuruVJ PuruVJ deleted the site/chore/update-deps branch August 22, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants