Skip to content

Conversation

@benmccann
Copy link
Member

@benmccann benmccann commented Aug 22, 2023

Our core web vitals have really taken a hit since enabling edge serving. I ran various configs against pagespeed.web.dev and the traditional serverless functions do the best. That's at least partially because I believe serverless functions default to running in us-east-1 where our supabase instance is located

Screenshot from 2023-08-18 11-50-40

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023

⚠️ No Changeset found

Latest commit: 026b813

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann changed the title site: serve authed pages from us-east regions site: turn off edge serving Aug 23, 2023
@benmccann benmccann requested a review from PuruVJ August 23, 2023 05:04
@benmccann benmccann changed the title site: turn off edge serving site: turn off edge serving for REPL Aug 23, 2023
@PuruVJ
Copy link
Collaborator

PuruVJ commented Aug 23, 2023

I still think we should give edge a chance. Set two regions close to the database and lets observe, I feel that alone will fix most issues. Edge is more resilient than serverless. With serverless, if one region goes down, it goes down for a long time until AWS fixes it. With edge, you got 500 once, and on second reload it'll switch to nearby region.

How about trying for these regions: ['iad1', 'cle1']?

@dummdidumm
Copy link
Member

dummdidumm commented Aug 23, 2023

I'm in favor of trying this out, given how big the dip is and how reliable it was before. Let's test, measure and potentially tweak later.

@dummdidumm dummdidumm merged commit d6f0981 into master Aug 23, 2023
@dummdidumm dummdidumm deleted the regions branch August 23, 2023 09:11
@ghost
Copy link

ghost commented Aug 23, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants