Skip to content

add teaser page #9210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: docs: "What's new in Svelte" October newsletter
merged 9 commits into from
Sep 15, 2023
Merged

add teaser page #9210

merged 9 commits into from
Sep 15, 2023

Conversation

@Rich-Harris
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 49165eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Conduitry
Conduitry requested changes Sep 15, 2023
View reviewed changes
Copy link
Member

@Conduitry Conduitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this image to the assets repo instead? It especially hurts my soul to check a binary file we know we're going to be getting rid of soon into this repo.

@Rich-Harris
Copy link
Member Author

done

gtm-nayan
gtm-nayan reviewed Sep 15, 2023
View reviewed changes
@PuruVJ
Copy link
Collaborator

PuruVJ commented Sep 15, 2023

Looks effing awesome! Left 2 comments on the vercel preview!

@Rich-Harris Rich-Harris merged commit 8667f0f into master Sep 15, 2023
@Rich-Harris Rich-Harris deleted the teaser branch September 15, 2023 15:32
kelvinsjk pushed a commit to kelvinsjk/svelte that referenced this pull request Oct 19, 2023
@Rich-Harris @kelvinsjk
add teaser page (sveltejs#9210)
c14e7e9 
* add teaser page

* add origin

* host card externally

* fix

* remove unused styles

* redesign

* black bg

* fix og image

* tweak font-sizes and alignment

---------

Co-authored-by: Rich Harris <rich.harris@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gtm-nayan gtm-nayan gtm-nayan left review comments

@Conduitry Conduitry Conduitry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rich-Harris @PuruVJ @Conduitry @gtm-nayan