fix: applying :global for +,~ sibling combinator when slots are present. fixes #9274 #9282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9274
For the following,
the style
:global(p) + span
could be applied because the slot could contain the required p element.The current code did not apply the style because
siblings.size===0
during compilation. To fix it, the existingfind_previous_sibling
andget_possible_element_siblings
functions were modified to also return whether a sibling slot has been found. We only flag a css selector as inapplicable if, in addition to the existing checks on sibling size and parent, if there are no previous sibling that are slots found.Svelte compiler rewrite
Please note that the Svelte codebase is currently being rewritten. Thus, it's best to hold off on new features or refactorings for the time being.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint