Skip to content

docs: enhance breaking change section #9674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2023
Merged

docs: enhance breaking change section #9674

merged 3 commits into from
Nov 28, 2023

Conversation

@dummdidumm
Copy link
Member

  • mention createRoot first, explain difference to mount
  • mentiond bind:this change
  • sub headings
  • adjust createRoot type that missed the events property

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@dummdidumm
docs: enhance breaking change section
ab88016 
- mention createRoot first, explain difference to mount
- mentiond bind:this change
- sub headings
- adjust createRoot type that missed the events property
@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8128c18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 10:16pm

Conduitry
Conduitry reviewed Nov 27, 2023
View reviewed changes
@dummdidumm @Conduitry
Update packages/svelte/src/internal/client/render.js
7d783d5 
Co-authored-by: Conduitry <git@chor.date>
@Rich-Harris Rich-Harris merged commit 75295ac into main Nov 28, 2023
@Rich-Harris Rich-Harris deleted the breaking-change-docs branch November 28, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Conduitry Conduitry Conduitry left review comments

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dummdidumm @Rich-Harris @Conduitry