-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
big old refactor #992
big old refactor #992
Conversation
Codecov Report
@@ Coverage Diff @@
## master #992 +/- ##
==========================================
+ Coverage 91.86% 91.99% +0.12%
==========================================
Files 112 115 +3
Lines 4169 4271 +102
Branches 1363 1359 -4
==========================================
+ Hits 3830 3929 +99
- Misses 144 148 +4
+ Partials 195 194 -1
Continue to review full report at Codecov.
|
Think this is probably in good enough shape to merge. Still more that could be done but the foundations have been laid. |
See #979. This doesn't look like much yet, but it hopefully gives a sense of my intentions. I have a good feeling about it.
A benefit that didn't occur to me before, but which is becoming obvious — this way of doing things is much more TypeScript-friendly.