[WIP] GitHub authentication #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
reviewed
Mar 25, 2018
routes/repl/_UserMenu.html
Outdated
| @@ -0,0 +1,58 @@ | |||
| <div class='user' on:mouseenter='set({ showMenu: true })' on:mouseleave='set({ showMenu: false })'> | |||
| <span>{{$user.displayName}}</span> | |||
There was a problem hiding this comment.
It's possible to have no displayName (I don't have one!) and so this should probably fall back to the username. Right now I'm seeing 'null' here.
|
Trying to load the SSR'd http://localhost:3000/guide directly is throwing an exception |
Conduitry
reviewed
Mar 25, 2018
| user: user && { | ||
| // strip access token | ||
| id: user.id, | ||
| name: user.name, |
There was a problem hiding this comment.
I think this should be username: user.username.
There was a problem hiding this comment.
yep, you're right — fixed
|
Saving/updating an existing gist looks like it mostly works, but it does lose README.md, data.json, and meta.json. |
|
Fixed all those points now, thanks @Conduitry. Some fairly substantial changes in this PR:
|
This was referenced Mar 25, 2018
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #211. The codebase is in a bad state though, so I'm also tidying some stuff up to make that easier