Skip to content

refactor: switch from .ts to .js with jsdoc #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 24, 2023
Merged

Conversation

dominikg
Copy link
Member

This PR is part 1 of a 2 part process.

  • Change all types to use jsdoc in vite-plugin-svelte, but keep .ts extension.
  • Cleanups and changes to tooling as needed

Part 2 in a separate PR:

  • rename .ts to .js
  • update package.json to only include src, point to src/index.js / d.ts
  • change build script to be typecheck only (we can remove it later but it is called from ecosystem-ci etc)
  • add changeset

@dominikg dominikg marked this pull request as ready for review May 23, 2023 18:26
@dominikg dominikg merged commit 962f22f into main May 24, 2023
@dominikg dominikg deleted the refactor/ts2jsdoc branch May 24, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants