Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkger task in favor of Go 1.16 embed package #75

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

svengreb
Copy link
Owner

Resolves #74

In #52 [1] a task for the github.com/markbates/pkger [2] Go module was
added, a tool for embedding static files into Go binaries.
The issue also includes the "Official Static Assets Embedding" section
which mentions that the task might be removed later on again as soon as
Go 1.16 [3] will be released which comes with toolchain support for
embedding static assets (files) [4] through the `embed` package [5].
Also see markbates/pkger#114 [6] for more details about the project
future of `pkger`.

The `pkger` package [7] has been removed and the `//go:embed` directive
should be used instead.

[1]: #52
[2]: https://pkg.go.dev/github.com/markbates/pkger
[3]: https://blog.golang.org/go1.16
[4]: https://golang.org/doc/go1.16#library-embed
[5]: https://pkg.go.dev/embed
[6]: markbates/pkger#114
[7]: https://pkg.go.dev/github.com/svengreb/wand@v0.4.1/pkg/task/pkger

GH-74
@svengreb svengreb added this to the 0.5.0 milestone Apr 21, 2021
@svengreb svengreb self-assigned this Apr 21, 2021
@svengreb svengreb merged commit 1fc1f25 into main Apr 21, 2021
@svengreb svengreb deleted the task/gh-74-remove-pkger-task-for-go-1.16-embed-pkg branch April 21, 2021 21:10
@svengreb svengreb removed their assignment Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pkger task in favor of Go 1.16 embed package
1 participant