New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove `ExecName` method from `Exec` interface again #88

Merged

svengreb merged 1 commit into main from task/gh-87-remove-execname-method-from-exec-interface

Apr 24, 2021

Owner

svengreb commented Apr 24, 2021

Resolves #87


          Remove ExecName method from Exec interface again

b66f70c

In GH-79 [1] a new `ExecName() string` method has been added to the
`Exec` interface [2] to improve the way how `RunnerExec` [3] handles the
name of the executable file, but it turned out that this is not useful
at all and also broke the separation of concern between the `Task` and
`Runner` interfaces.
Therefore the method has been removed again.

[1]: #79
[2]: https://pkg.go.dev/github.com/svengreb/wand/pkg/task#Exec
[3]: https://pkg.go.dev/github.com/svengreb/wand/pkg/task#RunnerExec

GH-87

svengreb added context-api scope-compatibility scope-quality type-task labels

svengreb added this to the 0.6.0 milestone

svengreb self-assigned this

svengreb merged commit 8b30110 into main

svengreb deleted the task/gh-87-remove-execname-method-from-exec-interface branch

April 24, 2021 19:03

svengreb removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

context-api scope-compatibility scope-quality type-task