Improve documentation for the --header parameter #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenstaro
requested changes
Apr 12, 2024
orwithout
commented
Apr 13, 2024
There was a problem hiding this comment.
Thank you for the review. Here are the updates made:
-
Improved Documentation: Enhanced clarity on
--headerusage, particularly regarding how conflicts with existing headers are handled. -
HSTS Example: Added an example in the README for enabling HSTS using
--header, essential for achieving an A+ rating on SSL Labs. -
Fullchain Certificates Usage: Documented the use of fullchain certificates with the
--tls-certoption to improve HTTPS security.
These changes aim to clarify usage and enhance security features. Please let me know if additional modifications are necessary.
|
Thanks! |
svenstaro
added a commit
that referenced
this pull request
Apr 26, 2024
Glad to contribute! And it means a lot to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more detailed explanation of the use of the parameter --header